Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flatbuffers] support iOS triplets #16843

Merged
merged 4 commits into from
Mar 24, 2021
Merged

[flatbuffers] support iOS triplets #16843

merged 4 commits into from
Mar 24, 2021

Conversation

luncliff
Copy link
Contributor

@luncliff luncliff commented Mar 23, 2021 •
edited
Loading

What does your PR fix?

Exclude flatc build target which requires BUNDLE DESTINATION. (config error when iOS triplets)

I encountered this issue while trying arm triplets for #15717, and found an old issue #7380.

Which triplets are supported/not supported? Have you updated the CI baseline?

4 iOS triplets should become available with this PR.

  • arm64-ios
  • arm-ios
  • x64-ios
  • x86-ios

Does your PR follow the maintainer guide?

Sure. I think this is the minimum change.

@luncliff
[flatbuffers] exclude 'flatc' for ios triplets
46aab41 
* building flatc requires BUNDLE DESTINATION
* increase port version
@luncliff luncliff marked this pull request as draft March 23, 2021 12:17
@luncliff
Copy link
Contributor Author

#15717 changes Port-Version of flatbuffers. To prevent a collision, changed to a draft.

@NancyLi1013 NancyLi1013 self-assigned this Mar 24, 2021
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Mar 24, 2021
@NancyLi1013 NancyLi1013 added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Mar 24, 2021
@NancyLi1013
Copy link
Contributor

Is this PR ready for review now @luncliff?

@luncliff luncliff marked this pull request as ready for review March 24, 2021 06:59
@luncliff
Copy link
Contributor Author

I think so.
I don't have a test project which uses flatbuffers in iOS in my hand... but the change is small(just disables flatc), so it won't be a matter I think.

@NancyLi1013
Copy link
Contributor

Thanks for your feedback.

Since these triplets are all community triplets, CI machine will not test these. Have you tested them locally?

@luncliff
Copy link
Contributor Author

Thanks for your feedback.

Since these triplets are all community triplets, CI machine will not test these. Have you tested them locally?

Yes. Without the executable build target, the port only builds several source files.

flatbuffers-ios.zip

@ras0219-msft ras0219-msft merged commit e37bd3f into microsoft:master Mar 24, 2021
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the PR!

@luncliff luncliff deleted the port/flatbuffers branch March 26, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luncliff @NancyLi1013 @ras0219-msft